Skip to content

Fix goto-symex' auto-objects feature #7177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix goto-symex' auto-objects feature #7177

wants to merge 1 commit into from

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented Sep 30, 2022 •
edited
Loading

The included test also demonstrates how to use it.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Sep 30, 2022 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.41%. Comparing base (2e6200a) to head (eb53ca4).

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #7177      +/-   ##
===========================================
+ Coverage    80.39%   80.41%   +0.01%     
===========================================
  Files         1688     1688              
  Lines       207403   207406       +3     
  Branches        73       73              
===========================================
+ Hits        166749   166776      +27     
+ Misses       40654    40630      -24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

martin-cs
martin-cs approved these changes Oct 3, 2022
View reviewed changes
Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but we do have to be a little careful of the "don't give semantics to undefined behaviour" rule.

@tautschnig tautschnig self-assigned this Nov 20, 2022
@tautschnig tautschnig changed the title KNOWNBUG test for goto-symex' auto-objects feature Fix goto-symex' auto-objects feature May 16, 2023
@tautschnig tautschnig force-pushed the feature/auto-objects branch from 4d1197b to e40ff4a Compare May 16, 2023 14:12
@tautschnig tautschnig force-pushed the feature/auto-objects branch from e40ff4a to 70e557e Compare May 16, 2023 14:24
@tautschnig tautschnig force-pushed the feature/auto-objects branch from 70e557e to e354f4e Compare April 23, 2024 08:53
@tautschnig
Fix goto-symex' auto-objects feature
eb53ca4 
The included test also demonstrates how to use it.
@tautschnig tautschnig force-pushed the feature/auto-objects branch from e354f4e to eb53ca4 Compare July 28, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-cs martin-cs martin-cs approved these changes

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@kroening kroening

@peterschrammel peterschrammel

Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tautschnig @martin-cs @kroening @peterschrammel